Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore(analytics): Allow analytics to be configured per env #21975

Open
wants to merge 3 commits into
base: develop
Choose a base branch
from
Open

chore(analytics): Allow analytics to be configured per env #21975

wants to merge 3 commits into from
+27 −16

Conversation

ilmotta
Copy link
Contributor

@ilmotta ilmotta commented Jan 22, 2025 •
edited
Loading

Fixes #21974

Summary

Allows MixPanel to be configured per environment. The hardcoded MixPanel app ID and token are removed from the code (see the parent issue for more details). The token can be exploited and that's by design in analytics tools https://developer.mixpanel.com/reference/project-token, but we are being too kind at the same time, so I'm removing that from code ;)

Areas that may be impacted

  • Analytics

Steps to test

I will test this PR myself.

  • Enable usage data during onboarding and from settings.
  • Check the events are published to the correct MixPanel project.

Note: to test the correct values are set-up in Jenkins for release builds we need to generate a release build. That's the reason I committed a change to the VERSION file with the PR number, as I believe this is the recommendation from infra team.

status: ready

@ilmotta ilmotta added the infra label Jan 22, 2025
@ilmotta ilmotta self-assigned this Jan 22, 2025
@ilmotta ilmotta requested review from siddarthkay and a team January 22, 2025 15:27
@ilmotta ilmotta force-pushed the ilmotta/configure-mixpanel-per-env branch from 7d89cf6 to 61bf682 Compare January 22, 2025 15:28
@status-im-auto
Copy link
Member

status-im-auto commented Jan 22, 2025 •
edited
Loading

Jenkins Builds

Click to see older builds (18)
❔ Commit #️⃣ Finished (UTC) Duration Platform Result
✔️ 61bf682 #3 2025-01-22 15:34:15 ~5 min tests 📄log
✔️ 61bf682 #3 2025-01-22 15:38:11 ~9 min android-e2e 🤖apk 📲
✔️ 61bf682 #3 2025-01-22 15:39:06 ~10 min android 🤖apk 📲
✔️ 61bf682 #3 2025-01-22 15:41:07 ~12 min ios 📱ipa 📲
✔️ 93040b8 #4 2025-02-11 09:28:29 ~7 min tests 📄log
✔️ 93040b8 #4 2025-02-11 09:30:59 ~9 min android-e2e 🤖apk 📲
✔️ 93040b8 #4 2025-02-11 09:35:31 ~14 min android 🤖apk 📲
✔️ 93040b8 #4 2025-02-11 09:36:53 ~15 min ios 📱ipa 📲
✔️ 898808c #6 2025-02-18 04:50:41 ~5 min tests 📄log
✔️ 898808c #6 2025-02-18 04:53:17 ~8 min android-e2e 🤖apk 📲
✔️ 898808c #6 2025-02-18 04:54:08 ~9 min android 🤖apk 📲
✔️ 898808c #6 2025-02-18 04:56:19 ~11 min ios 📱ipa 📲
❌ 4bf762e #7 2025-02-18 10:15:29 ~12 sec android 📄log
❌ 4bf762e #7 2025-02-18 10:15:30 ~13 sec ios 📄log
❌ 4bf762e #8 2025-02-18 10:15:39 ~11 sec android-e2e 📄log
❌ 4bf762e #8 2025-02-18 10:15:39 ~11 sec android 📄log
❌ 4bf762e #8 2025-02-18 10:15:46 ~12 sec ios 📄log
✔️ 4bf762e #8 2025-02-18 10:20:06 ~4 min tests 📄log
❔ Commit #️⃣ Finished (UTC) Duration Platform Result
✔️ 72482b9 #9 2025-02-18 10:34:12 ~6 min tests 📄log
✔️ 72482b9 #9 2025-02-18 10:37:31 ~9 min android-e2e 🤖apk 📲
✔️ 72482b9 #9 2025-02-18 10:38:19 ~10 min android 🤖apk 📲
✔️ 72482b9 #9 2025-02-18 10:41:50 ~14 min ios 📱ipa 📲
✔️ b12d40a #10 2025-02-19 02:04:33 ~5 min tests 📄log
✔️ b12d40a #10 2025-02-19 02:06:38 ~7 min android 🤖apk 📲
✔️ b12d40a #10 2025-02-19 02:07:27 ~8 min android-e2e 🤖apk 📲
✔️ b12d40a #10 2025-02-19 02:10:16 ~10 min ios 📱ipa 📲

@ilmotta
Copy link
Contributor Author

ilmotta commented Jan 22, 2025

Thanks for the swift reviews guys!

@siddarthkay I tagged you as a reviewer to help us configure the vars in Jenkins. The shadow-cljs code already allows passing the vars to the initialization code in status-go, so I believe it's just a matter of passing down the vars from Jenkins. The parent issue has the details about what we expect to be configured #21974 in Jenkins. When the time is appropriate for you, could you help us by adding the vars to Jenkins? Thanks!

@status-im-auto
Copy link
Member

75% of end-end tests have passed

Total executed tests: 8
Failed tests: 2
Expected to fail tests: 0
Passed tests: 6
Not executed tests: 2

IDs of not executed tests: 741554,741555 

IDs of failed tests: 740490,702843

Not executed tests (2)

Click to expand
  • Rerun not executed tests

    • Failed tests (2)

    Click to expand
  • Rerun failed tests

    • Class TestWalletOneDevice:

    1. test_wallet_balance_mainnet, id: 740490

    Device 1: Find `Button` by `accessibility id`: `network-dropdown`
    Device 1: Tap on found: Button 

    critical/test_wallet.py:260: in test_wallet_balance_mainnet
    self.errors.verify_no_errors()
base_test_case.py:176: in verify_no_errors
    pytest.fail('\n '.join([self.errors.pop(0) for _ in range(len(self.errors))]))
 For the Ether the wrong value 0.0062 is shown, expected 0.0052 in total
E    For the Status the wrong value 13.0 is shown, expected 10.0 in total
E    For the Ether the wrong value 0.0011 is shown, expected 0.0001 on Optimism
E    For the Status the wrong value 3.0 is shown, expected 0 on Optimism



    Class TestCommunityMultipleDeviceMerged:

    1. test_community_message_edit, id: 702843

    Device 1: Find EmojisNumber by xpath: //*[starts-with(@text,'Message AFTER edit 2 (Edited)')]/ancestor::android.view.ViewGroup[@content-desc='chat-item']/../..//*[@content-desc='emoji-reaction-2']/android.widget.TextView[2]
    Device 1: Element EmojisNumber text is equal to 1 

    critical/chats/test_public_chat_browsing.py:380: in test_community_message_edit
    self.errors.verify_no_errors()
base_test_case.py:176: in verify_no_errors
    pytest.fail('\n '.join([self.errors.pop(0) for _ in range(len(self.errors))]))
 Message is not edited



    Device sessions

    Passed tests (6)

    Click to expand

    Class TestCommunityOneDeviceMerged:

    1. test_restore_multiaccount_with_waku_backup_remove_profile_switch, id: 703133
    Device sessions

    2. test_community_copy_and_paste_message_in_chat_input, id: 702742
    Device sessions

    Class TestWalletMultipleDevice:

    1. test_wallet_send_asset_from_drawer, id: 727230
    2. test_wallet_send_eth, id: 727229

    Class TestWalletOneDevice:

    1. test_wallet_add_remove_regular_account, id: 727231

    Class TestOneToOneChatMultipleSharedDevicesNewUi:

    1. test_1_1_chat_non_latin_messages_stack_update_profile_photo, id: 702745
    Device sessions

    @ilmotta
    Copy link
    Contributor Author

    ilmotta commented Feb 3, 2025

    @siddarthkay, please let me know when you have set up the CI with the vars MIXPANEL_APP_ID and MIXPANEL_TOKEN so I can proceed with testing this PR. Thank you 🦾

    @churik churik added the blocked label Feb 3, 2025
    @ilmotta ilmotta force-pushed the ilmotta/configure-mixpanel-per-env branch from 61bf682 to 93040b8 Compare February 11, 2025 09:20
    @siddarthkay
    Copy link
    Contributor

    I can proceed with testing this PR.

    Can get this done by tomorrow!
    Thanks for the patience on this so far.

    @siddarthkay siddarthkay requested a review from jakubgs as a code owner February 18, 2025 04:42
    @siddarthkay siddarthkay force-pushed the ilmotta/configure-mixpanel-per-env branch 3 times, most recently from 4bf762e to 72482b9 Compare February 18, 2025 10:27
    @siddarthkay
    Copy link
    Contributor

    we can see credential usage of mixpanel in jenkins

    Screenshot 2025-02-18 at 4 04 19 PM

    @churik churik removed the blocked label Feb 18, 2025
    @ilmotta ilmotta force-pushed the ilmotta/configure-mixpanel-per-env branch from 72482b9 to b12d40a Compare February 19, 2025 01:59
    Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
    Reviewers

    @seanstrom seanstrom seanstrom approved these changes

    @flexsurfer flexsurfer flexsurfer approved these changes

    @Parveshdhull Parveshdhull Parveshdhull approved these changes

    @siddarthkay siddarthkay Awaiting requested review from siddarthkay

    @jakubgs jakubgs Awaiting requested review from jakubgs jakubgs is a code owner

    Assignees

    @ilmotta ilmotta

    Labels
    infra skip-manual-qa
    Projects
    Pipeline for QA
    Status: E2E Tests
    Milestone
    No milestone
    Development

    Successfully merging this pull request may close these issues.

    Segregate centralized analytics per environment
    8 participants
    @ilmotta @status-im-auto @siddarthkay @seanstrom @flexsurfer @Parveshdhull @churik @mariia-skrypnyk